absurdfarce commented on code in PR #1998:
URL:
https://github.com/apache/cassandra-java-driver/pull/1998#discussion_r1904348905
##########
guava-shaded/pom.xml:
##########
@@ -46,12 +46,8 @@
<artifactId>error_prone_annotations</artifactId>
</exclusion>
<exclusion>
- <groupId>com.google.j2objc</groupId>
- <artifactId>j2objc-annotations</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>animal-sniffer-annotations</artifactId>
+ <groupId>com.google.guava</groupId>
+ <artifactId>listenablefuture</artifactId>
Review Comment:
The [blog post](https://groups.google.com/g/guava-announce/c/Km82fZG68Sw) I
referenced earlier provides a more complete picture of what happened
@lukasz-antoniak:
```
Some Android library developers have told us that they would like to use
ListenableFuture in their APIs, but they know that a full Guava dependency
would be bad for apps that don't use Proguard. To address this, we are planning
to release a separate artifact that contains only ListenableFuture.
```
I'm not quite sure I understand all of this; seems to me like you'd either
want ListenableFuture by itself or Guava (with ListenableFuture still there)...
which in turn means there's no real reason for Guava to depend on the
listenablefuture lib. That change clearly was introduced to avoid seeing
duplicate class definition errors... but I'm not sure how that's accomplished.
Regardless, I agree that removing the dependency should be harmless. For
extra confirmation I confirmed that the high-numbered listenablefuture lib does
indeed have no classes:
```
$ jar tf
/work/maven/repo/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar
META-INF/MANIFEST.MF
META-INF/
META-INF/maven/
META-INF/maven/com.google.guava/
META-INF/maven/com.google.guava/listenablefuture/
META-INF/maven/com.google.guava/listenablefuture/pom.xml
META-INF/maven/com.google.guava/listenablefuture/pom.properties
```
I've got a final DS Jenkins run going with the most recent changes.
Assuming there's no regression there (and I strongly suspect there won't be
one) we're good to go on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
