jameshartig commented on PR #1834: URL: https://github.com/apache/cassandra-gocql-driver/pull/1834#issuecomment-2582940762
> It seems like misbehavior that MapScan doesn't get the original data from the database. I agree with @joao-r-reis, I think we need more consensus that "original data" is not the default go values and is actually `nil`. Again, I've seen cases where one or the other are preferred. I don't think we can make this large of a change based on 1-2 cases. I don't even know how many devs are using `MapScan` outside of exoteric situations. > imo MapScan doc is not clear enough when we're talking about null values. We can definitely clarify the docs. > I think there is no issue with backward compatibility because this functionality will be added to 2.0. You're changing a public interface which means anything implementing `TypeInfo` will need to be updated to support the new behavior. > Also, I'm a little confused about the argument that this could be implemented on the user side, for example, SliceMap, can be easily implemented by the user, but we still provide such convenient functionality. I can appreciate your frustration but we want to decrease the surface area of the API and not increase it. We're stuck with `SliceMap` now but I agree it should have been more scrutinized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
