smiklosovic commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1911964726


##########
src/java/org/apache/cassandra/cql3/constraints/ColumnConstraintScalar.java:
##########
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3.constraints;
+
+
+import java.io.IOException;
+
+import org.apache.cassandra.cql3.ColumnIdentifier;
+import org.apache.cassandra.cql3.CqlBuilder;
+import org.apache.cassandra.cql3.Operator;
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.db.marshal.AbstractType;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+import org.apache.cassandra.schema.ColumnMetadata;
+
+public class ColumnConstraintScalar implements ColumnConstraint
+{
+    public final ColumnIdentifier param;
+    public final Operator relationType;
+    public final String term;
+
+    public final static Serializer serializer = new Serializer();
+
+    public final static class Raw
+    {
+        public final ColumnIdentifier param;
+        public final Operator relationType;
+        public final String term;
+
+        public Raw(ColumnIdentifier param, Operator relationType, String term)
+        {
+            this.param = param;
+            this.relationType = relationType;
+            this.term = term;
+        }
+
+        public ColumnConstraintScalar prepare()
+        {
+            return new ColumnConstraintScalar(param, relationType, term);
+        }
+    }
+
+    public ColumnConstraintScalar(ColumnIdentifier param, Operator 
relationType, String term)
+    {
+        this.param = param;
+        this.relationType = relationType;
+        this.term = term;
+    }
+
+    @Override
+    public void evaluate(Class<? extends AbstractType> valueType, Object 
columnValue)
+    {
+        Number columnValueNumber;
+        float sizeConstraint;
+
+        try
+        {
+            columnValueNumber = (Number) columnValue;
+            sizeConstraint = Float.parseFloat(term);
+        }
+        catch (NumberFormatException exception)
+        {
+            throw new ConstraintViolationException(param + " and " + term + " 
need to be numbers.");
+        }
+
+        switch (relationType)
+        {
+            case EQ:
+                if (Float.compare(columnValueNumber.floatValue(), 
sizeConstraint) != 0)
+                    throw new ConstraintViolationException(param + " value 
should be exactly " + sizeConstraint);
+                break;
+            case NEQ:
+                if (Double.compare(columnValueNumber.floatValue(), 
sizeConstraint) == 0)
+                    throw new ConstraintViolationException(param + " value 
should be different from " + sizeConstraint);
+                break;
+            case GT:
+                if (columnValueNumber.floatValue() <= sizeConstraint)
+                    throw new ConstraintViolationException(param + " value 
should be larger than " + sizeConstraint);
+                break;
+            case LT:
+                if (columnValueNumber.floatValue() >= sizeConstraint)
+                    throw new ConstraintViolationException(param + " value 
should be smaller than " + sizeConstraint);
+                break;
+            case GTE:
+                if (columnValueNumber.floatValue() < sizeConstraint)
+                    throw new ConstraintViolationException(param + " value 
should be larger or equal than " + sizeConstraint);
+                break;
+            case LTE:
+                if (columnValueNumber.floatValue() > sizeConstraint)
+                    throw new ConstraintViolationException(param + " value 
should be smaller or equal than " + sizeConstraint);
+                break;
+            default:
+                throw new ConstraintViolationException("Invalid relation type: 
" + relationType);
+        }
+    }
+
+    @Override
+    public void validate(ColumnMetadata columnMetadata) throws 
InvalidConstraintDefinitionException
+    {
+        if (!(columnMetadata.type instanceof 
org.apache.cassandra.db.marshal.NumberType))
+            throw new InvalidConstraintDefinitionException(param + " is not a 
number");
+    }
+
+    @Override
+    public String toString()
+    {
+        return param + " " + relationType + " " + term;
+    }
+
+    @Override
+    public IVersionedSerializer<ColumnConstraint> serializer()
+    {
+        return serializer;

Review Comment:
   This might be OK too. But if you only ever access `serializer` via this 
method, then `serializer` might be probably `private`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to