smiklosovic commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1911966419


##########
src/java/org/apache/cassandra/cql3/constraints/ColumnConstraints.java:
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3.constraints;
+
+import org.apache.cassandra.cql3.CqlBuilder;
+import org.apache.cassandra.db.marshal.AbstractType;
+import org.apache.cassandra.db.marshal.CompositeType;
+import org.apache.cassandra.db.marshal.DynamicCompositeType;
+import org.apache.cassandra.db.marshal.MapType;
+import org.apache.cassandra.db.marshal.TupleType;
+import org.apache.cassandra.db.marshal.UserType;
+import org.apache.cassandra.io.IVersionedAsymmetricSerializer;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+import org.apache.cassandra.schema.ColumnMetadata;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.collect.ImmutableSet;
+
+// group of constraints for the column
+public class ColumnConstraints implements ColumnConstraint
+{
+    public static final Serializer serializer = new Serializer();
+
+    private static final Set<Class<? extends AbstractType>> UNSUPPORTED_TYPES 
= ImmutableSet.of(MapType.class,
+                                                                               
            TupleType.class,
+                                                                               
            UserType.class,
+                                                                               
            CompositeType.class,
+                                                                               
            DynamicCompositeType.class);
+
+    private final List<ColumnConstraint> constraints;
+
+    public ColumnConstraints(List<ColumnConstraint> constraints)
+    {
+        this.constraints = new ArrayList<>(constraints);
+    }
+
+    @Override
+    public IVersionedSerializer<ColumnConstraint> serializer()
+    {
+        return serializer;
+    }
+
+    @Override
+    public void appendCqlTo(CqlBuilder builder)
+    {
+        for (ColumnConstraint constraint : constraints)
+        {
+            constraint.appendCqlTo(builder);
+        }
+    }
+
+    @Override
+    public void evaluate(Class<? extends AbstractType> valueType, Object 
columnValue) throws ConstraintViolationException
+    {
+        for (ColumnConstraint constraint : constraints)
+        {
+            constraint.evaluate(valueType, columnValue);
+        }
+    }
+
+    public List<ColumnConstraint> getConstraints()
+    {
+        return constraints;
+    }
+
+    public boolean isEmpty()
+    {
+        return constraints.isEmpty();
+    }
+
+    @Override
+    public void validate(ColumnMetadata columnMetadata) throws 
InvalidConstraintDefinitionException
+    {
+        if (UNSUPPORTED_TYPES.contains(columnMetadata.type.getClass()))
+        {
+            throw new InvalidConstraintDefinitionException("Constraint cannot 
be defined on column '"
+                                                           + 
columnMetadata.name + "' with type: "
+                                                           + 
columnMetadata.type.asCQL3Type());
+        }
+        for (ColumnConstraint constraint : constraints)
+        {
+            constraint.validate(columnMetadata);
+        }
+    }
+
+    public static class Noop extends ColumnConstraints
+    {
+        public static final Noop INSTANCE = new Noop();
+
+        public Noop()
+        {
+            super(Collections.emptyList());
+        }
+    }
+
+    public final static class Raw
+    {
+        private final List<ColumnConstraint> constraints;
+
+        public Raw(List<ColumnConstraint> constraints)
+        {
+            this.constraints = constraints;
+        }
+
+        public Raw()
+        {
+            this.constraints = Collections.emptyList();
+        }
+
+        public ColumnConstraints prepare()
+        {
+            return new ColumnConstraints(constraints);
+        }
+    }
+
+    public static class Serializer implements 
IVersionedSerializer<ColumnConstraint>
+    {
+        @Override
+        public void serialize(ColumnConstraint columnConstraint, 
DataOutputPlus out, int version) throws IOException
+        {
+            ColumnConstraints constraints = (ColumnConstraints) 
columnConstraint;
+            out.writeInt(constraints.getConstraints().size());
+
+            for (ColumnConstraint constraint : constraints.getConstraints())
+            {
+                out.writeUTF(constraint.getClass().toString());
+                constraint.serializer().serialize(constraint, out, version);
+            }
+        }
+
+        @Override
+        public ColumnConstraints deserialize(DataInputPlus in, int version) 
throws IOException
+        {
+            List<ColumnConstraint> columnConstraints = new ArrayList<>();
+            int numberOfConstraints = in.readInt();
+            for (int i = 0; i < numberOfConstraints; i++)
+            {
+                String columnConstraintClassName = in.readUTF();
+                ColumnConstraint constraint = 
ConstraintSerializerFactory.getCqlConditionSerializer(columnConstraintClassName)
+                        .deserialize(in, version);
+                columnConstraints.add(constraint);
+            }
+            return new ColumnConstraints(columnConstraints);
+        }
+
+        @Override
+        public long serializedSize(ColumnConstraint columnConstraint, int 
version)
+        {
+            ColumnConstraints constraints = (ColumnConstraints) 
columnConstraint;
+            long constraintsSize = 0;
+            for (ColumnConstraint constraint : constraints.getConstraints())
+                constraintsSize += 
constraint.serializer().serializedSize(constraint, version);
+            return constraintsSize;
+        }
+    }
+
+    public static class ConstraintSerializerFactory
+    {
+        public static IVersionedAsymmetricSerializer<ColumnConstraint, 
ColumnConstraint> getCqlConditionSerializer(String columnConstraintClassName)
+        {
+            if 
(columnConstraintClassName.equals(FunctionColumnConstraint.class.getName()))

Review Comment:
   you might probably save some space if you used "simple class name". 
   
   `out.writeUTF(constraint.getClass().toString());` -> 
`out.writeUTF(constraint.getClass().getSimpleName());`
   
   so this would be
   
   `if 
(columnConstraintClassName.equals(FunctionColumnConstraint.class.getSimpleName()))`
   
   or you can have an enum behind that like
   
   ````
   enum ConstraintsSerializers
   {
       FUNCTION(FunctionColumnConstraint.serializer),
       SCALAR(ColumnConstraintScalar.serializer)
   }
   ````
   
   and then, instead fully qualified class name, you would serialize just an 
integer - position of that enum. That should save you some space.
   
   ````
       public static enum ConstraintsSerializers
       {
           FUNCTION(FunctionColumnConstraint.serializer),
           SCALAR(ColumnConstraintScalar.serializer);
       
           private static ConstraintsSerializers[] values = 
ConstraintsSerializers.values(); 
           
           private Serializer serializer;
   
           ConstraintsSerializers(Serializer serializer)
           {
               this.serializer = serializer;
           }
   
           // you would serialize just an int (it might be actually just a 
`byte`)
           Serializer getSerializer(int i)
           {
               return values[i].serializer;
           }
       }
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to