smiklosovic commented on code in PR #3562: URL: https://github.com/apache/cassandra/pull/3562#discussion_r1913026688
########## src/java/org/apache/cassandra/cql3/CqlConstraintFunctionExecutor.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + + +import java.util.List; +import java.util.Map; + +import org.apache.cassandra.schema.TableMetadata; + +/** + * Interface to be implemented by functions that are executed as part of CQL constraints. + */ +public interface CqlConstraintFunctionExecutor +{ + /** + * This method returns the function name to be executed. + * + * @return + */ + String getName(); + + /** + * Method that provides the execution of the condition. It can either succeed or throw a {@link ConstraintViolationException}. + * + * @param args + * @param relationType + * @param term + * @param tableMetadata + * @param columnValues + */ + void checkConstraint(List<ColumnIdentifier> args, Operator relationType, String term, TableMetadata tableMetadata, Map<String, String> columnValues); + + /** + * Method that validates that a condition is valid. This method is called when the CQL constraint is created to determine + * if the CQL statement is valid or needs to be rejected as invalid. + * @param args + * @param relationType + * @param term + * @param tableMetadata + */ + void validate(List<ColumnIdentifier> args, Operator relationType, String term, TableMetadata tableMetadata); Review Comment: @yifan-c I have suggested this solution instead of string matching https://github.com/apache/cassandra/pull/3562#discussion_r1911966419 ########## src/java/org/apache/cassandra/cql3/CqlConstraintFunctionExecutor.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + + +import java.util.List; +import java.util.Map; + +import org.apache.cassandra.schema.TableMetadata; + +/** + * Interface to be implemented by functions that are executed as part of CQL constraints. + */ +public interface CqlConstraintFunctionExecutor +{ + /** + * This method returns the function name to be executed. + * + * @return + */ + String getName(); + + /** + * Method that provides the execution of the condition. It can either succeed or throw a {@link ConstraintViolationException}. + * + * @param args + * @param relationType + * @param term + * @param tableMetadata + * @param columnValues + */ + void checkConstraint(List<ColumnIdentifier> args, Operator relationType, String term, TableMetadata tableMetadata, Map<String, String> columnValues); + + /** + * Method that validates that a condition is valid. This method is called when the CQL constraint is created to determine + * if the CQL statement is valid or needs to be rejected as invalid. + * @param args + * @param relationType + * @param term + * @param tableMetadata + */ + void validate(List<ColumnIdentifier> args, Operator relationType, String term, TableMetadata tableMetadata); Review Comment: @yifan-c I have suggested this solution instead of string matching https://github.com/apache/cassandra/pull/3562#discussion_r1911966419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
