smiklosovic commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1914483782
##########
src/java/org/apache/cassandra/cql3/constraints/ColumnConstraint.java:
##########
@@ -89,5 +79,5 @@ public static int getSerializer(Class clazz)
*
* @return the Constraint type serializer
*/
- ConstraintsSerializers getConstraintType();
+ ConstraintsSerializers getConstraintSerializerType();
Review Comment:
@bbotella
Why not to rename `ConstrantSerializers` enum to `ConstraintType`? Then you
would have a method called "`getConstraintType` which would return
`ConstraintType` which makes more sense to me and reads better.
The fact that `ConstraintType` holds serializers does not mean whole enum
has to be named `ConstraintSerializers`. What you have in that enum are types
of constraints which have accidentally their serializers too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
