Mmuzaf commented on code in PR #3742:
URL: https://github.com/apache/cassandra/pull/3742#discussion_r1913642169
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java:
##########
@@ -175,6 +176,16 @@ private Map<String, Object>
convertStatsTableToMap(StatsTable table)
mpTable.put("top_tombstone_partitions", table.topTombstonePartitions);
if (locationCheck)
mpTable.put("sstables_in_correct_location",
table.isInCorrectLocation);
+
+ mpTable.put("sai_local_query_latency",String.format("%01.3f",
table.saiQueryLatencyMs));
+ mpTable.put("sai_post_filtering_read_latency",String.format("%01.3f",
table.saiPostFilteringReadLatencyms));
+ mpTable.put("sai_disk_used_bytes",table.saiDiskUsedBytes);
+ mpTable.put("sai_sstable_indexes_hit",table.saiSSTableIndexesHit);
+ mpTable.put("sai_index_segments_hit",table.saiIndexSegmentsHit);
+ mpTable.put("sai_rows_filtered",table.saiRowsFiltered);
+ mpTable.put("sai_total_query_timeouts",table.saiTotalQueryTimeouts);
+ mpTable.put("sai_queryable_total_indexes",
table.saiTotalQueryableIndexRatio);
Review Comment:
Why do we assign a ration to "sai_queryable_total_indexes"? As far as I can
see, `"TotalIndexCount"` and `"TotalQueryableIndexCount"` are different
metrics, so ration is not the right value for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
