Mmuzaf commented on code in PR #3742:
URL: https://github.com/apache/cassandra/pull/3742#discussion_r1915658139
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java:
##########
@@ -175,6 +176,16 @@ private Map<String, Object>
convertStatsTableToMap(StatsTable table)
mpTable.put("top_tombstone_partitions", table.topTombstonePartitions);
if (locationCheck)
mpTable.put("sstables_in_correct_location",
table.isInCorrectLocation);
+
+ mpTable.put("sai_local_query_latency",String.format("%01.3f",
table.saiQueryLatencyMs));
+ mpTable.put("sai_post_filtering_read_latency",String.format("%01.3f",
table.saiPostFilteringReadLatencyms));
+ mpTable.put("sai_disk_used_bytes",table.saiDiskUsedBytes);
+ mpTable.put("sai_sstable_indexes_hit",table.saiSSTableIndexesHit);
+ mpTable.put("sai_index_segments_hit",table.saiIndexSegmentsHit);
+ mpTable.put("sai_rows_filtered",table.saiRowsFiltered);
+ mpTable.put("sai_total_query_timeouts",table.saiTotalQueryTimeouts);
+ mpTable.put("sai_queryable_total_indexes",
table.saiTotalQueryableIndexRatio);
Review Comment:
My point was about the arg naming, `sai_queryable_total_indexes` should it
be `sai_total_queryable_index_ratio`? As the `sai_queryable_total_indexes`
already has its corresponding metric `"TotalQueryableIndexCount"` which differs
from the ratio. Am I missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
