ekaterinadimitrova2 commented on code in PR #3696: URL: https://github.com/apache/cassandra/pull/3696#discussion_r1913797677
########## conf/jvm21-server.options: ########## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +########################################################################### +# jvm21-server.options # +# # +# See jvm-server.options. This file is specific for Java 21 and newer. # +########################################################################### + +################# +# GC SETTINGS # +################# + + +### Generational ZGC settings +-XX:+UseZGC +-XX:+ZGenerational +# Temporary workaround for jamm's incorrect default CompressedOops; if you're using ZGC this needs to be set +-XX:-UseCompressedOops Review Comment: > I propose we move to merge this branch w/default set to Generational ZGC, however upon merge, reach out to the ML to indicate what we did, merged, and where it's configured. Go the "ask for forgiveness rather than permission" route. Agreed > I know GC and the defaults has been pretty contentious in the past, however specifically when it comes to genZGC the results are so stark that I haven't seen anybody advocate for G1 or CMS over it in any discussions, so I think we're good to just go w/lazy consensus but signpost what we did after merge. Since we change it with the introduction of new JDK and not for the old JDK versions that sounds reasonable to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
