jmckenzie-dev commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r1913770130
##########
build.xml:
##########
@@ -307,6 +307,72 @@
<equals arg1="${ant.java.version}" arg2="17"/>
</condition>
+ <resources id="_jvm21_arg_items">
+ <string>-Djdk.attach.allowAttachSelf=true</string>
+
+ <string>-XX:+UseZGC</string>
+ <string>-XX:+ZGenerational</string>
+
+ <!-- Temporary workaround for jamm having incorrect default
CompressedOops for JDK21 -->
+ <string>-XX:-UseCompressedOops</string>
+
+ <!-- Have jamm tell us what it sees for memory layout on start for
debugging purposes -->
+ <string>-Dorg.github.jamm.strategies.LogInfoAtStartup-true</string>
+
+ <!-- <string>-XX:+UseLargePages</string> -->
+ <!-- <string>-XX:+SoftMaxHeapSize=12G</string> --> <!-- Max size ZGC
will _attempt_ to stay below -->
+ <!-- Disable returning memory to the OS -->
+ <string>-XX:-ZUncommit</string>
+ <!-- <string>-XX:ZUncommitDelay=300</string> -->
+
+ <!-- Pay the tax up front to pretouch memory to smooth out latency
later -->
+ <string>-XX:+AlwaysPreTouch</string>
+
+ <!-- Need to explicitly allow security manager on JDK21; deprecated
for removal -->
+ <string>-Djava.security.manager=allow</string>
+
+ <string>--add-exports java.base/jdk.internal.misc=ALL-UNNAMED</string>
+ <string>--add-exports java.base/jdk.internal.ref=ALL-UNNAMED</string>
+ <string>--add-exports java.base/sun.nio.ch=ALL-UNNAMED</string>
+ <string>--add-exports
java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED</string>
+
+ <string>--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED</string>
+ <string>--add-exports java.rmi/sun.rmi.server=ALL-UNNAMED</string>
+ <string>--add-exports
java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED</string>
+ <string>--add-exports java.sql/java.sql=ALL-UNNAMED</string>
+ <string>--add-exports java.base/java.lang.ref=ALL-UNNAMED</string>
+ <string>--add-exports java.base/java.lang.reflect=ALL-UNNAMED</string>
+ <string>--add-exports jdk.unsupported/sun.misc=ALL-UNNAMED</string>
+ <string>--add-exports
jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</string>
+
+ <string>--add-opens java.base/java.lang.module=ALL-UNNAMED</string>
+ <string>--add-opens java.base/java.net=ALL-UNNAMED</string>
+ <string>--add-opens java.base/jdk.internal.loader=ALL-UNNAMED</string>
+ <string>--add-opens java.base/jdk.internal.ref=ALL-UNNAMED</string>
+ <string>--add-opens java.base/jdk.internal.reflect=ALL-UNNAMED</string>
+ <string>--add-opens java.base/jdk.internal.math=ALL-UNNAMED</string>
+ <string>--add-opens java.base/jdk.internal.module=ALL-UNNAMED</string>
+ <string>--add-opens
java.base/jdk.internal.util.jar=ALL-UNNAMED</string>
Review Comment:
I'll remove it and we'll see what happens. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]