dcapwell commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1915324641
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -654,7 +657,8 @@ public ResultMessage.Rows executeInternal(QueryState state,
userLimit,
userPerPartitionLimit,
pageSize,
- aggregationSpec);
+ aggregationSpec,
+ true);
Review Comment:
walking this code its hard to understand stand what `local` means and I
would leap to judgment about what it means... only once you fully walk to the
thing that needs this boolean do you see
```
boolean allowsPotentialTxnConflicts,
```
leading this name and meaning to be confusing...
https://cassandra.apache.org/_/development/code_style.html
```
Enums for Boolean Properties
Prefer an enum to boolean properties and parameters, unless clarity will be
harmed (e.g. helper methods that accept a computed boolean predicate result, of
the same name as used in the method they assist). Try to balance name clashes
that would affect static imports, against clear and simple names that represent
the behavioural switch.
```
enum could help in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
