aweisberg commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1915414725
##########
src/java/org/apache/cassandra/tcm/ClusterMetadataService.java:
##########
@@ -756,7 +756,12 @@ public ClusterMetadata
fetchLogFromPeerOrCMS(ClusterMetadata metadata, InetAddre
public ClusterMetadata awaitAtLeast(Epoch epoch) throws
InterruptedException, TimeoutException
{
- return log.awaitAtLeast(epoch);
+ return awaitAtLeast(epoch, -1, null);
+ }
+
+ public ClusterMetadata awaitAtLeast(Epoch epoch, long timeout, TimeUnit
unit) throws InterruptedException, TimeoutException
Review Comment:
OK, I thought it was strange for `DurationSpec` (I thought it was for
config?) to be used to communicate a timeout since it doesn't follow the idiom
for Java and can't be passed directly to the primitives that actually implement
timeouts.
@beobal why is `DurationSpec` used for TCM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
