dcapwell commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1915658020
##########
src/java/org/apache/cassandra/service/reads/range/RangeCommandIterator.java:
##########
@@ -187,6 +199,50 @@ static int computeConcurrencyFactor(int totalRangeCount,
int rangesQueried, int
return concurrencyFactor;
}
+ private PartitionIterator executeAccord(ClusterMetadata cm,
PartitionRangeReadCommand rangeCommand, ConsistencyLevel cl)
+ {
+ //TODO (nicetohave): This is very inefficient because it will not map
to the command store owned ranges
+ // so every command store will return results up to the limit and most
could be discarded.
+ // Really we want to split the ranges by command stores owned ranges
and then query one at a time
+ // For this to work well it really needs to integrated upwards where
the ranges to query are being picked
+ AsyncTxnResult result = StorageProxy.readWithAccord(cm, rangeCommand,
ImmutableList.of(rangeCommand.dataRange().keyRange()), cl, requestTime);
Review Comment:
you are right, the `IN` clause makes it non-range. I couldn't quickly find
a range read that could violate token ordering.... i couldn't get ORDER BY
working in those cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
