aweisberg commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1915672601


##########
src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java:
##########
@@ -320,6 +330,17 @@ public UnfilteredRowIterator 
applyToPartition(UnfilteredRowIterator partition)
         return Transformation.apply(iterator, new Logging());
     }
 
+    public static void log(UnfilteredPartitionIterator partitions, String id, 
boolean fullDetails)

Review Comment:
   Because it's difficult to tell if a wrong answer is because of coordinator 
side filtering or because the results were never returned and it's not 
straightforward to log a read response.
   
   I could get rid of the double read by using the `ReadResponse` pretty easily 
and convert this to a trace level log statement. Would that address it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to