smiklosovic commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1916358959
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java:
##########
@@ -543,14 +550,17 @@ public String table()
return name.getName();
}
- public void addColumn(ColumnIdentifier column, CQL3Type.Raw type,
boolean isStatic, ColumnMask.Raw mask)
+ public void addColumn(ColumnIdentifier column, CQL3Type.Raw type,
boolean isStatic, ColumnMask.Raw mask, ColumnConstraints.Raw constraints)
{
-
if (null != rawColumns.put(column, new ColumnProperties.Raw(type,
mask)))
throw ire("Duplicate column '%s' declaration for table '%s'",
column, name);
if (isStatic)
staticColumns.add(column);
+ if (null == constraints)
+ columnConstraints.put(column, new ColumnConstraints.Noop());
Review Comment:
`new ColumnConstraints.Noop()` can be singleton, applicable everywhere this
occurs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
