smiklosovic commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1916350258
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -275,6 +319,11 @@ public boolean isMasked()
return mask != null;
}
+ public boolean hasConstraint()
+ {
+ return !columnConstraints.isEmpty();
Review Comment:
@bbotella can not this be "cached"? A simple private boolean in
ColumnMetadata saying if constraints are empty or not so we dont need to call
this method every time ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
