dcapwell commented on code in PR #3794:
URL: https://github.com/apache/cassandra/pull/3794#discussion_r1917456633
##########
test/distributed/org/apache/cassandra/distributed/upgrade/ClusterMetadataUpgradeHarryTest.java:
##########
@@ -56,7 +59,28 @@ public class ClusterMetadataUpgradeHarryTest extends
UpgradeTestBase
public void simpleUpgradeTest() throws Throwable
{
AtomicReference<Interruptible> executor = new AtomicReference<>();
+ AtomicLong loops = new AtomicLong(0);
Listener listener = new Listener();
+ Runnable awaitHarryProgress = () -> {
+ long startingLoopCount = loops.get();
+ long deadline = startingLoopCount + 100;
Review Comment:
100 was randomly selected... on my m1 max laptop 100 loops is ~1s... so this
is less progress than previous.... our definition of work is also different as
we track the read/write so we know 100 writes have at least happened... which
feels fine for this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
