dcapwell commented on code in PR #3794: URL: https://github.com/apache/cassandra/pull/3794#discussion_r1917457773
########## test/distributed/org/apache/cassandra/distributed/upgrade/ClusterMetadataUpgradeHarryTest.java: ########## @@ -56,7 +59,28 @@ public class ClusterMetadataUpgradeHarryTest extends UpgradeTestBase public void simpleUpgradeTest() throws Throwable { AtomicReference<Interruptible> executor = new AtomicReference<>(); + AtomicLong loops = new AtomicLong(0); Listener listener = new Listener(); + Runnable awaitHarryProgress = () -> { + long startingLoopCount = loops.get(); + long deadline = startingLoopCount + 100; + long nowNanos = System.nanoTime(); + boolean matched = false; + for (int i = 0; i < 20 && !(matched = loops.get() >= deadline); i++) Review Comment: 20 * 500ms = 10s, which is what the old logic used.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org