dcapwell commented on code in PR #3836:
URL: https://github.com/apache/cassandra/pull/3836#discussion_r1931263960
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -332,29 +333,12 @@ private IInvokableInstance newInstance()
++generation;
IClassTransformer transformer = classTransformer == null ? null :
classTransformer.initialise();
ClassLoader classLoader = new InstanceClassLoader(generation,
config.num(), version.classpath, sharedClassLoader, sharedClassPredicate,
transformer);
- Consumer<Throwable> stabilityInspector;
Review Comment:
this is problematic as this logic is shared with `UpgradeCluster`, which is
expected to support forward and previous versions. This logic tried to bring
`JVMStabilityInspector` into the jvm-dtest API space.
`org.apache.cassandra.distributed.api.IInstance#uncaughtException` was added
specifically to avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
