belliottsmith commented on code in PR #3836:
URL: https://github.com/apache/cassandra/pull/3836#discussion_r1937061376
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -332,29 +333,12 @@ private IInvokableInstance newInstance()
++generation;
IClassTransformer transformer = classTransformer == null ? null :
classTransformer.initialise();
ClassLoader classLoader = new InstanceClassLoader(generation,
config.num(), version.classpath, sharedClassLoader, sharedClassPredicate,
transformer);
- Consumer<Throwable> stabilityInspector;
- {
- try
- {
- Class<?> owner =
classLoader.loadClass(JVMStabilityInspector.class.getName());
- Method method = owner.getMethod("inspectThrowable",
Throwable.class);
Review Comment:
could you elaborate? Do you mean the target of this method should simply be
"uncaughtException" rather than "inspectThrowable"? If so, why not just make
that change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
