jameshartig commented on code in PR #1836:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1836#discussion_r1934011626
##########
host_source.go:
##########
@@ -87,13 +88,29 @@ func (c *cassVersion) unmarshal(data []byte) error {
c.Minor, err = strconv.Atoi(v[1])
if err != nil {
- return fmt.Errorf("invalid minor version %v: %v", v[1], err)
+ vMinor := strings.Split(v[1], "-")
+ if len(vMinor) < 2 {
+ return fmt.Errorf("invalid minor version %v: %v", v[1],
err)
+ }
+ c.Minor, err = strconv.Atoi(vMinor[0])
+ if err != nil {
+ return fmt.Errorf("invalid minor version %v: %v", v[1],
err)
+ }
+ c.AdditionalNotation = vMinor[1]
Review Comment:
How common will there be multiple qualifiers? I'm fine with `Suffix` but if
there isn't realistically going to be more than one qualifier, then I think
`Qualifier` is still more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
