joao-r-reis commented on code in PR #1836:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1836#discussion_r1934104008
##########
host_source.go:
##########
@@ -87,13 +88,29 @@ func (c *cassVersion) unmarshal(data []byte) error {
c.Minor, err = strconv.Atoi(v[1])
if err != nil {
- return fmt.Errorf("invalid minor version %v: %v", v[1], err)
+ vMinor := strings.Split(v[1], "-")
+ if len(vMinor) < 2 {
+ return fmt.Errorf("invalid minor version %v: %v", v[1],
err)
+ }
+ c.Minor, err = strconv.Atoi(vMinor[0])
+ if err != nil {
+ return fmt.Errorf("invalid minor version %v: %v", v[1],
err)
+ }
+ c.AdditionalNotation = vMinor[1]
Review Comment:
Honestly I don't know, I just noticed there's logic to handle this in the
java driver and thought we would do the same here but I don't remember the last
time I saw a C* version with multiple qualifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
