jameshartig commented on PR #1793: URL: https://github.com/apache/cassandra-gocql-driver/pull/1793#issuecomment-2622066353
> I will say that making it a string will make it more error prone because the user might use the wrong string format of the uuid. This will not be an issue if the user just calls `hostInfo.HostID()` but at that point might as well just make the parameter a `*hostInfo` instead. Wdyt about this @jameshartig Hmm that is a good point, but by only accepting a `*HostInfo` the only way to use it is by calling `GetHosts` and then looping (and optionally filtering) yourself. That's not the end of the world but it does seem less than ideal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
