jameshartig commented on PR #1793: URL: https://github.com/apache/cassandra-gocql-driver/pull/1793#issuecomment-2622105697
@worryg0d Actually thinking about it more, I dislike that `GetHosts` requires 2 round-trips, and that seems excessive to always require when you want to choose a host, especially if you already have the `HostId`. I don't think we should be encouraging people to hold onto `*HostInfo`'s which they might do if the only way to get one is calling `GetHosts`. I'm doubling down on making it accept a `HostId string` and we can just look in the pool for that hostId and not need to do any round-trips. We should mention in the method comment for `SetHost` that it's recommended to get the hostId from `*HostInfo.HostID()` to encourage people use it but it's not required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
