belliottsmith commented on code in PR #3823:
URL: https://github.com/apache/cassandra/pull/3823#discussion_r1934233862
##########
src/java/org/apache/cassandra/service/accord/AccordJournalTable.java:
##########
@@ -492,15 +489,15 @@ public K key()
}
@Override
- public void readAllForKey(K key, RecordConsumer<K> reader)
+ public void readAllForKey(K key, RecordConsumer<K> reader, boolean
includeUpdates)
Review Comment:
I think compaction might cause problems actually, since we aren't merging
records here I think? We're just loading new records then earlier ones. But we
need to really merge on read, as I think we treat them all as newer than the
records we had on startup, even though we could have intermixed older data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
