belliottsmith commented on code in PR #3823:
URL: https://github.com/apache/cassandra/pull/3823#discussion_r1934235665
##########
src/java/org/apache/cassandra/service/accord/AccordJournalTable.java:
##########
@@ -492,15 +489,15 @@ public K key()
}
@Override
- public void readAllForKey(K key, RecordConsumer<K> reader)
+ public void readAllForKey(K key, RecordConsumer<K> reader, boolean
includeUpdates)
Review Comment:
Hrm, or in fact it looks like we aren't even looking at sstable segments.
So, are we disabling the compactor that flushes to journal until this
completes? if so it might be safe, but we would need to make sure we can
guarantee this doesn't get started until we finish as it will silently corrupt
things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
