ifesdjeen commented on code in PR #162:
URL: https://github.com/apache/cassandra-accord/pull/162#discussion_r1934475634
##########
accord-core/src/main/java/accord/coordinate/FetchData.java:
##########
@@ -79,6 +79,18 @@ private static class FetchRequest
final BiConsumer<? super FetchResult, Throwable> callback;
public FetchRequest(Known fetch, TxnId txnId, InvalidIf invalidIf,
@Nullable Timestamp executeAt, Participants<?> fetchKeys, EpochSupplier
lowEpoch, EpochSupplier highEpoch, BiConsumer<? super FetchResult, Throwable>
callback)
+ {
Review Comment:
nit: unused constructor; but could be used in C*?
##########
accord-core/src/main/java/accord/coordinate/FetchData.java:
##########
@@ -79,6 +79,18 @@ private static class FetchRequest
final BiConsumer<? super FetchResult, Throwable> callback;
public FetchRequest(Known fetch, TxnId txnId, InvalidIf invalidIf,
@Nullable Timestamp executeAt, Participants<?> fetchKeys, EpochSupplier
lowEpoch, EpochSupplier highEpoch, BiConsumer<? super FetchResult, Throwable>
callback)
+ {
Review Comment:
nit: unused constructor; but could be used in C*?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
