belliottsmith commented on code in PR #162: URL: https://github.com/apache/cassandra-accord/pull/162#discussion_r1935441345
########## accord-core/src/main/java/accord/primitives/Timestamp.java: ########## @@ -277,6 +277,18 @@ public int compareTo(@Nonnull Timestamp that) return c; } + public boolean isAtLeastByEpochAndHlc(@Nonnull Timestamp that) + { + if (this == that) return true; + int cmpEpoch = Long.compare(this.epoch(), that.epoch()); + int cmpHlc = Long.compare(this.hlc(), that.hlc()); + if (cmpEpoch < 0 || cmpHlc < 0) return false; + if (cmpEpoch > 0 || cmpHlc > 0) return true; Review Comment: yes, it's possibly to agree two different transactions to execute at (2,1) and (1,2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org