joao-r-reis commented on code in PR #1793:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1937381213


##########
query_executor.go:
##########
@@ -41,6 +41,7 @@ type ExecutableQuery interface {
        Keyspace() string
        Table() string
        IsIdempotent() bool
+       GetHostID() string

Review Comment:
   Yeah I don't think we need to treat `ExecutableQuery` as a "public" 
interface to be implemented by users, it's a bit messy right now and I actually 
want to spend some time investigating how we could clean up this part of the 
API as part of https://github.com/apache/cassandra-gocql-driver/pull/1848 
ideally in time for the 2.0 release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to