jameshartig commented on code in PR #1793:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1793#discussion_r1937466056
##########
session.go:
##########
@@ -2177,6 +2203,15 @@ func (t *traceWriter) Trace(traceId []byte) {
}
}
+// GetHosts returns a list of hosts found via queries to system.local and
system.peers
+func (s *Session) GetHosts() ([]*HostInfo, error) {
Review Comment:
I'm thinking we _could_ call it `GetAllHosts` to clarify that it will get
all hosts but I'm not sure if that's strictly necessarily. We could call the
host filter within the method when we're looping but tbh I'm not sure if users
want it filtered or not. I think until we get feedback we just need to pick a
path and be prepared to add another method (either add GetAllHosts later or
GetHosts later that does filtering). @joao-r-reis do you have thoughts on the
filtering vs not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
