smiklosovic commented on code in PR #3831:
URL: https://github.com/apache/cassandra/pull/3831#discussion_r1939208017
##########
src/java/org/apache/cassandra/cql3/statements/schema/CopyTableStatement.java:
##########
@@ -229,12 +234,37 @@ public void validate(ClientState state)
validateDefaultTimeToLive(attrs.asNewTableParams());
}
+ private void cloneIndexesIfNeeded(TableMetadata.Builder builder,
TableMetadata sourceTableMeta, KeyspaceMetadata targetKeyspaceMeta)
+ {
+ if (createLikeOption == CreateLikeOption.INDEX)
+ {
+ Indexes.Builder idxBuilder = Indexes.builder();
+ for (IndexMetadata indexMetadata : sourceTableMeta.indexes)
Review Comment:
What if `sourceTableMeta.indexes` is empty? What if source table does not
have any index? Then you are creating `idxBuilder` unnecessarily.
I would expand on the previous suggestion and did:
````
if (createLikeOption != CreateLikeOption.INDEX ||
sourceTableMeta.indexes.isEmpty())
return;
...
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
