Maxwell-Guo commented on code in PR #3831:
URL: https://github.com/apache/cassandra/pull/3831#discussion_r1950175525
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -808,23 +808,18 @@ def test_complete_in_create_table_like(self):
'memtable',
'memtable_flush_period_in_ms',
'caching', 'comment',
- 'min_index_interval',
'speculative_retry', 'additional_write_policy', 'cdc', 'read_repair'])
- self.trycompletions('CREATE TABLE ' + 'new_table LIKE old_table WITH ',
- choices=['allow_auto_snapshot',
- 'bloom_filter_fp_chance', 'compaction',
- 'compression',
- 'default_time_to_live',
'gc_grace_seconds',
- 'incremental_backups',
- 'max_index_interval',
- 'memtable',
- 'memtable_flush_period_in_ms',
- 'caching', 'comment',
- 'min_index_interval',
'speculative_retry', 'additional_write_policy', 'cdc', 'read_repair'])
+ 'min_index_interval',
+ 'speculative_retry',
'additional_write_policy',
+ 'cdc', 'read_repair',
+ 'ALL'])
+ self.trycompletions('CREATE TABLE new_table LIKE old_table WITH ALL ',
+ choices=['<identifier>', '='])
Review Comment:
There will be keyword "ALL" or property after keyword "WITH" and for
property ,
see
```
<propertyOrOption> ::= <property>
| "ALL" <identifier>
```
as for <property> , it is also a key value map with "=" in the middle.
So the ALL was treated as the key of <property>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
