bbotella commented on code in PR #3355:
URL: https://github.com/apache/cassandra/pull/3355#discussion_r1949175421
##########
src/java/org/apache/cassandra/cql3/terms/Lists.java:
##########
@@ -414,12 +414,14 @@ static void doAppend(Term.Terminal value, ColumnMetadata
column, UpdateParameter
dataSize += cell.dataSize();
}
Guardrails.collectionSize.guard(dataSize,
column.name.toString(), false, params.clientState);
+ Guardrails.collectionListSize.guard(dataSize,
column.name.toString(), false, params.clientState);
Review Comment:
I hear you, and it makes sense. But I kind of like the verbosity of having
the two separate guardrails explicitly called. I think from a readability
standpoint, it makes it easier to see "both" guardrails being checked in order,
instead of hiding the check of the former as part of the check of the latter.
Again, on the fence on this one, so, if you feel this is the right way to go, I
can definitely change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
