yifan-c commented on code in PR #3355: URL: https://github.com/apache/cassandra/pull/3355#discussion_r1950084562
########## conf/cassandra.yaml: ########## @@ -2365,8 +2363,8 @@ drop_compact_storage_enabled: false # of non-frozen collections there could be unaccounted parts of the collection on the sstables. This is done this way to # prevent read-before-write. The guardrail is also checked at sstable write time to detect large non-frozen collections, # although in that case exceeding the fail threshold will only log an error message, without interrupting the operation. -# Also, this guardrail can be used with the generic collection_size_fail_threshold. The lowest of the two guardrail will -# be the one enforced. +# When collection_map_size_warn_threshold is defined, it takes the precedence over generic collection_size_fail_threshold +# guardrail. Review Comment: This still seems wrong to me. ```suggestion # When collection_map_size_warn_threshold and/or collection_map_size_fail_threshold are defined, they take the precedence # over the cooresponding collection_size_warn_threshold and/or collection_size_fail_threshold. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
