maedhroz commented on code in PR #3884:
URL: https://github.com/apache/cassandra/pull/3884#discussion_r1949998349
##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -275,6 +275,14 @@ public boolean isValid(ByteBuffer term)
}
}
+ /**
+ * @return {@code true} if the empty values of the given type should be
excluded from indexing
+ */
+ public boolean skipsEmptyValue()
+ {
+ return !indexType.allowsEmpty() || !isLiteral();
Review Comment:
The alternative here is to use `isEmptyValueMeaningless()` instead of
`!isLiteral()`, which would mean empty values for boolean and a few other
things would no longer be indexed. This makes sense if you don't believe
querying on empty values for non-string types is useful, but it obviously
diverges from what non-index filtering queries seem to do right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
