maedhroz commented on code in PR #3884:
URL: https://github.com/apache/cassandra/pull/3884#discussion_r1950008516
##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -541,6 +549,9 @@ else if (isBigDecimal())
public ByteSource asComparableBytes(ByteBuffer value,
ByteComparable.Version version)
{
+ if (value.remaining() == 0)
+ return ByteSource.EMPTY;
Review Comment:
Possibly...I'll think this one over a bit. Keep in mind that these values
only have to be consistent in index space. i.e. As long as this is the value
queries would use for empty, it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
