dcapwell commented on code in PR #169:
URL: https://github.com/apache/cassandra-accord/pull/169#discussion_r1950141421
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -486,15 +486,10 @@ public <State, SystemUnderTest> void
check(Commands<State, SystemUnderTest> comm
}
catch (Throwable t)
{
- try
- {
- commands.destroySut(sut, t);
- commands.destroyState(state, t);
- }
- catch (Throwable t2)
- {
- t.addSuppressed(t2);
- }
+ State finalState = state;
+ safeHandle(t, () -> commands.onFailure(finalState,
sut, maybeRewriteHistory(history, historyTiming), t));
Review Comment:
`onFailure` is mostly there for when i do tests in a loop i want to get a
summary of the history i am looking at. For example while working on
CASSANDRA-20156 i want to find a shorter history, so getting a summary of whats
going on helps me see if i should ignore the failing seed.
Also, if `destorySut` failed `destoryState` wouldn't get called, so this
logic is now properly handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
