belliottsmith commented on code in PR #169:
URL: https://github.com/apache/cassandra-accord/pull/169#discussion_r1952465454
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -469,6 +554,35 @@ public TopologyManager(TopologySorter.Supplier sorter,
Agent agent, Id self, Sch
this.localConfig = localConfig;
}
+ public EpochsSnapshot epochsSnapshot()
+ {
+ ImmutableList.Builder<EpochsSnapshot.Epoch> builder =
ImmutableList.builder();
Review Comment:
Suggestion: when we know the size of the contents and are already wrapping
the contents in some object, I prefer to use a raw array. If not, we should
provide the size to the builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
