frankgh commented on code in PR #191:
URL: https://github.com/apache/cassandra-sidecar/pull/191#discussion_r1953101868


##########
server/src/main/java/org/apache/cassandra/sidecar/server/Server.java:
##########
@@ -302,11 +303,15 @@ protected void validate()
      */
     protected Future<String> scheduleInternalPeriodicTasks(String deploymentId)
     {
-        periodicTaskExecutor.schedule(new HealthCheckPeriodicTask(vertx,
-                                                                  
sidecarConfiguration,
-                                                                  
instancesMetadata,
-                                                                  
executorPools,
-                                                                  metrics));
+        HealthCheckPeriodicTask healthCheckPeriodicTask = new 
HealthCheckPeriodicTask(
+        sidecarConfiguration,
+                                                                   
instancesMetadata,
+                                                                   
executorPools,
+                                                                   metrics);

Review Comment:
   Can we fix the formatting here?
   ```suggestion
           HealthCheckPeriodicTask healthCheckPeriodicTask = new 
HealthCheckPeriodicTask(sidecarConfiguration,
                                                                                
         instancesMetadata,
                                                                                
         executorPools,
                                                                                
         metrics);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to