yifan-c commented on code in PR #191:
URL: https://github.com/apache/cassandra-sidecar/pull/191#discussion_r1953112682
##########
scripts/build-shaded-dtest-jar-local.sh:
##########
@@ -26,7 +26,7 @@ CASSANDRA_VERSION=$(cat build.xml | grep 'property
name="base.version"' | awk -F
GIT_HASH=$(git rev-parse --short HEAD)
DTEST_ARTIFACT_ID=${ARTIFACT_NAME}-local
DTEST_JAR_DIR="$(dirname "${SCRIPT_DIR}/")/dtest-jars"
-
+DTEST_JAR_DIR=${CASSANDRA_DEP_DIR:-$DTEST_JAR_DIR}
Review Comment:
I do not think the dtest jars should be placed in a central place and
shared. The projects can depend on different SHAs. Unlike the local maven repo,
where the jars can be distinguished by version. Sharing the dtest jars could
cause confusion.
It is unrelated to the patch, just to bring it up, do not need to address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
