tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1955434962
##########
tools/sstableloader/test/unit/org/apache/cassandra/tools/LoaderOptionsTest.java:
##########
@@ -215,5 +215,40 @@ public void checkPermission(Permission perm, Object
context)
System.setSecurityManager(null);
}
}
+
+ // Copied from OfflineToolUtils
Review Comment:
Ultimately ended up doing this instead of having sstableloader-test depend
on test classes, as the test classes already depend on the sstableloader build,
this didn't feel like it was worth doing, so just went for copying the minimal
amount of shared code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
