Re: [PR] CASSANDRA-20328: Migrate sstableloader code to its own tools directory and artifact [cassandra]

[via GitHub]

tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1955438117


##########
build.xml:
##########
@@ -2064,6 +2158,16 @@
     <install pomFile="${build.dir}/${final.name}.pom"
              file="${build.dir}/${final.name}-javadoc.jar"
              classifier="javadoc"/>
+
+    <!-- the cassandra-sstableloader jar -->
+    <install pomFile="${build.dir}/${final.name}-sstableloader.pom"

Review Comment:
   Tested this locally and it does appear to work:
   
   ```kotlin
   plugins {
       id("java")
   }
   
   group = "org.example"
   version = "1.0-SNAPSHOT"
   
   repositories {
       mavenCentral()
       mavenLocal()
   }
   
   dependencies {
       
implementation("org.apache.cassandra:cassandra-sstableloader:5.1-SNAPSHOT")
       testImplementation(platform("org.junit:junit-bom:5.10.0"))
       testImplementation("org.junit.jupiter:junit-jupiter")
   }
   
   tasks.test {
       useJUnitPlatform()
   }
   ```
   
   ![Screenshot From 2025-02-13 
19-37-11](https://github.com/user-attachments/assets/ad767c1b-4670-4d63-a215-9654fda4269a)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org