tolbertam commented on code in PR #2018:
URL:
https://github.com/apache/cassandra-java-driver/pull/2018#discussion_r1965928778
##########
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/SniSslEngineFactory.java:
##########
@@ -38,9 +38,15 @@ public class SniSslEngineFactory implements SslEngineFactory
{
private final SSLContext sslContext;
private final CopyOnWriteArrayList<String> fakePorts = new
CopyOnWriteArrayList<>();
+ private final boolean allowDnsReverseLookupSan;
public SniSslEngineFactory(SSLContext sslContext) {
+ this(sslContext, true);
+ }
+
+ public SniSslEngineFactory(SSLContext sslContext, boolean
allowDnsReverseLookupSan) {
Review Comment:
Didn't dawn on me at the time that `SniSslEngineFactory` does not access
`DriverContext` so we can't make use of it unless programatically (outside of
`CloudConfigFactory`), but I suppose if someone wants to use it separately,
they can programmatically and in which case this adds some functionality :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
