tolbertam commented on code in PR #2018:
URL:
https://github.com/apache/cassandra-java-driver/pull/2018#discussion_r1965921240
##########
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/SniSslEngineFactory.java:
##########
@@ -38,9 +38,16 @@ public class SniSslEngineFactory implements SslEngineFactory
{
private final SSLContext sslContext;
private final CopyOnWriteArrayList<String> fakePorts = new
CopyOnWriteArrayList<>();
+ private final boolean allowDnsReverseLookupSan;
public SniSslEngineFactory(SSLContext sslContext) {
this.sslContext = sslContext;
+ this.allowDnsReverseLookupSan = true;
Review Comment:
tiny nit: can we change this constructor to `this(sslContext, true);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
