bbotella commented on code in PR #189:
URL: https://github.com/apache/cassandra-sidecar/pull/189#discussion_r1970656316
##########
server/src/main/java/org/apache/cassandra/sidecar/utils/SidecarClientProvider.java:
##########
@@ -76,6 +77,21 @@ public SidecarClient get()
return client;
}
+ public void close(Promise<Void> completion)
+ {
+ LOGGER.info("Closing Sidecar Client...");
+ try
+ {
+ client.close();
+ Thread.sleep(100);
Review Comment:
@frankgh identified a bug in vertx itself, that completing promises so close
together may cause problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
