yifan-c commented on code in PR #189:
URL: https://github.com/apache/cassandra-sidecar/pull/189#discussion_r1972493905
##########
server/src/main/java/org/apache/cassandra/sidecar/server/Server.java:
##########
@@ -167,9 +167,7 @@ public Future<CompositeFuture> close()
periodicTaskExecutor.close(periodicTaskExecutorPromise);
closingFutures.add(periodicTaskExecutorPromise.future());
- Promise<Void> closeSidecarClientPromise = Promise.promise();
- sidecarClientProvider.close(closeSidecarClientPromise);
- closingFutures.add(closeSidecarClientPromise.future());
+ sidecarClientProvider.close();
Review Comment:
Still need to add it in the future chain.
```suggestion
closingFutures.add(Future.future(p -> {
sidecarClientProvider.close();
p.complete();
}));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
