rustyrazorblade commented on code in PR #3606:
URL: https://github.com/apache/cassandra/pull/3606#discussion_r1976733394
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -934,6 +934,9 @@ else if (conf.max_value_size.toMebibytes() >= 2048)
break;
}
+ if (conf.compressed_read_ahead_buffer_size.toKibibytes() > 0 &&
conf.compressed_read_ahead_buffer_size.toKibibytes() < 256)
Review Comment:
I think to lower this limit, we'd need a pretty compelling reason, with a
specific example. The benefit would be an incredibly small reduction in memory
usage, and we'd see a TON more IO. I don't think there's a system that exists
on this planet where that would be useful. It would be like if reading from
main memory was faster than the CPU cache.
I'm pretty firmly against making things unnecessarily configurable, so if
there's a request to make this configurable, please also include the technical
justification, not just a hand wavey hypothetical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
