Maxwell-Guo commented on code in PR #3606:
URL: https://github.com/apache/cassandra/pull/3606#discussion_r1976947360


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -934,6 +934,9 @@ else if (conf.max_value_size.toMebibytes() >= 2048)
                 break;
         }
 
+        if (conf.compressed_read_ahead_buffer_size.toKibibytes() > 0 && 
conf.compressed_read_ahead_buffer_size.toKibibytes() < 256)

Review Comment:
   Hey @jrwest ,I don't want to modify this value, I'm just curious about why 
this value is set to 256 instead of 512 or 128. I believe you must have some 
basis. Of course, this does not affect the patch being incorporated. The test 
results have met many people's expectations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to