frankgh commented on code in PR #193:
URL: https://github.com/apache/cassandra-sidecar/pull/193#discussion_r1980263205


##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -544,6 +551,45 @@ public void streamCdcSegments(SidecarInstance 
sidecarInstance,
                 .build(), streamConsumer);
     }
 
+    /**
+     * Get configs for all the services in the "configs" table inside 
sidecar's internal
+     * keyspace
+     *
+     * @return List of services and their corresponding configs
+     */
+    public CompletableFuture<GetServicesConfigPayload> getServicesConfig()
+    {
+        return executor.executeRequestAsync(requestBuilder()
+                       .request(new GetServicesConfigRequest())
+                       .build());
+    }
+
+    /**
+     * Update config for a given service in "configs" table in internal 
sidecar keyspace
+     *
+     * @param serviceConfig service for which the configs are being updated
+     * @param config the updated config
+     * @return updated config
+     */
+    public CompletableFuture<PutCdcServiceConfigPayload> 
putCdcServiceConfig(ServiceConfig serviceConfig, Map<String, String> config)
+    {
+        return executor.executeRequestAsync(requestBuilder()
+                       .request(new PutServiceConfigRequest(serviceConfig, new 
PutCdcServiceConfigPayload(config)))
+                       .build());
+    }
+
+    /**
+     * Deletes configs for a given service in "configs" table in internal 
sidecar keyspace
+     *
+     * @param serviceConfig service for which the configs are being deleted
+     */
+    public CompletableFuture<Void> deleteCdcServiceConfig(ServiceConfig 
serviceConfig)

Review Comment:
   forgot about this one, is this cdc specific? or is it more a generic config?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to