yifan-c commented on code in PR #193:
URL: https://github.com/apache/cassandra-sidecar/pull/193#discussion_r1980386177
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcConfigImplTest.java:
##########
@@ -130,11 +131,8 @@ void testConfigsWhenConfigsAreNotEmpty() throws
InterruptedException
CdcConfigImpl cdcConfig =
new CdcConfigImpl(mockCdcConfiguration(),
mockSchemaKeyspaceConfiguration(), cdcConfigAccessor, kafkaConfigAccessor,
executor);
- while (!cdcConfig.isConfigReady())
- {
- Thread.sleep(1000);
- }
- assertThat(cdcConfig.dc()).isEqualTo("DC1");
+ loopAssert(5000, ()-> assertThat(cdcConfig.isConfigReady()).isTrue());
Review Comment:
hmm... the timeout is in seconds. `5` is probably wanted instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
